This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
CloneDialog: support non-admin users #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried not to interfiere with CloneDialog component much, because it it targeted against stable v2.0.0 |
Pull Request Test Coverage Report for Build 2170
💛 - Coveralls |
atiratree
force-pushed
the
fixCloneDialogPermission
branch
from
5155c9b
to
b917868
Compare
mareklibra
reviewed
Jul 22, 2019
| <Button | ||
| bsStyle="primary" | ||
| onClick={this.cloneVm} | ||
| disabled={!(this.state.valid && dataVolumesValid && pvcsValid)} |
There was a problem hiding this comment.
We should handle error state more explicitly - the user should be informed about transition from loading to error state.
I believe rendering info about just the most serious issue (as filtered by Firehose) is enough.
mareklibra
suggested changes
Jul 22, 2019
|
added error handling |
mareklibra
approved these changes
Jul 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bz: https://bugzilla.redhat.com/show_bug.cgi?id=1726193
sibling PR: kubevirt/web-ui#416