This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
make DNS1123 validation more verbose #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2202
💛 - Coveralls |
mareklibra
reviewed
Jul 25, 2019
|
|
||
| export const addMissingSubject = (sentence, subject) => { | ||
| const c = sentence ? sentence.charAt(0) : ''; | ||
| return c.toLowerCase() !== c ? sentence : `${_.capitalize(subject)} ${sentence}`; |
There was a problem hiding this comment.
Vivat future i18n effort :-(
There was a problem hiding this comment.
This feature is already implemented in both fork and openshift/console. It just doesn't have its own function.
i18n will be resolved once its time comes
mareklibra
approved these changes
Jul 31, 2019
|
Needs rebase, otherwise lgtm |
atiratree
force-pushed
the
kubevirt.fixVMList
branch
from
a851c89
to
008d0e3
Compare
|
rebased |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: https://bugzilla.redhat.com/show_bug.cgi?id=1710901