This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
deprecate baseTemplates to simplify loading and OS list flicker #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- disable fields when loading
Pull Request Test Coverage Report for Build 1850
💛 - Coveralls |
|
+1 for removing mocked templates |
|
I agree that mock templates can be removed now, as the kubevirt's deployment has already settled down and templates are mandatory part of it. In addition, the dialog won't be rendered without kubevirt installed. |
mareklibra
reviewed
Jul 25, 2019
| @@ -329,6 +330,7 @@ CreateVmWizard.propTypes = { | |||
| k8sPatch: PropTypes.func.isRequired, | |||
| k8sKill: PropTypes.func.isRequired, | |||
| onHide: PropTypes.func.isRequired, | |||
| templatesLoaded: PropTypes.bool, | |||
There was a problem hiding this comment.
I left comment regarding this prop in openshift/console#2157
mareklibra
approved these changes
Jul 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable fields when loading
bug: https://bugzilla.redhat.com/show_bug.cgi?id=1730390
@mareklibra @rawagner
IMO
web-ui-componentsbase mock templatesshouldn't be needed anymore. Current usage causes inconsistent behaviour on user's side.Thoughts?