Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

validate template sources with missing DataVolume #526

Merged
merged 1 commit into from
Jul 30, 2019
Merged

validate template sources with missing DataVolume #526

merged 1 commit into from
Jul 30, 2019

Conversation

atiratree
Copy link
Contributor

@atiratree atiratree force-pushed the kubevirt.fixTemplatesSourceValidation branch from 8ae94b0 to c1941c8 Compare July 25, 2019 13:32
@atiratree
Copy link
Contributor Author

scree

@coveralls
Copy link

coveralls commented Jul 25, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2185

  • 14 of 17 (82.35%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 82.513%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/templates.js 0 3 0.0%
Totals Coverage Status
Change from base Build 2178: 0.008%
Covered Lines: 4017
Relevant Lines: 4662
💛 - Coveralls

@mareklibra
Copy link
Contributor

Snapshots need to be updated

@atiratree atiratree force-pushed the kubevirt.fixTemplatesSourceValidation branch from c1941c8 to f15b74c Compare July 26, 2019 08:15
@atiratree
Copy link
Contributor Author

updated

@mareklibra mareklibra merged commit d47d328 into kubevirt:master Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mareklibra mareklibra mareklibra approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atiratree @coveralls @mareklibra @kubevirt-bot @suomiy