Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

v2v: move v2v-vmware ConfigMap to kubevirt-hyperconverged namespace #532

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

mareklibra
Copy link
Contributor

@mareklibra mareklibra commented Aug 1, 2019

More safe to avoid unrelated modifications.

Follow-up for #507


Sample v2v-vmware ConfigMap reflecting change in this PR:

oc apply -f - <<EOF
apiVersion: v1
kind: ConfigMap
metadata:
  namespace: kubevirt-hyperconverged
  name: v2v-vmware
data:
  v2v-conversion-image: [V2V-CONVERSION-IMAGE]
  kubevirt-vmware-image: [KUBEVIRT-VMWARE-IMAGE]
  kubevirt-vmware-image-pull-policy: IfNotPresent
EOF

More safe to avoid unrelated modifications.
@coveralls
Copy link

coveralls commented Aug 1, 2019

Pull Request Test Coverage Report for Build 1875

  • 1 of 6 (16.67%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 82.71%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/k8s/requests/v2v/startV2VvmwareController.js 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/k8s/requests/v2v/startV2VvmwareController.js 1 11.67%
Totals Coverage Status
Change from base Build 1870: -0.06%
Covered Lines: 4053
Relevant Lines: 4695

💛 - Coveralls

@mareklibra
Copy link
Contributor Author

Cc @jwmatthews

@jwmatthews
Copy link

cc @jmontleon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants