This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Enhance getVmiIpAddresses() function #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1930
💛 - Coveralls |
mareklibra
changed the title
mareklibra
force-pushed
the
ipAddresses
branch
2 times, most recently
from
d885c78
to
5e4dbb0
Compare
mareklibra
changed the title
Enhanced to deal with both `ipAddress` and `ipAddresses`, children of `vmi.status.interfaces`. More info: https://kubevirt.io/api-reference/master/definitions.html#_v1_virtualmachineinstancenetworkinterface
mareklibra
force-pushed
the
ipAddresses
branch
from
5e4dbb0
to
9d12cd2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced to deal with both
ipAddressandipAddresses,children of
vmi.status.interfaces.More info: https://kubevirt.io/api-reference/master/definitions.html#_v1_virtualmachineinstancenetworkinterface