This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Align vmware secret with DNS 1123 #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2311
💛 - Coveralls |
mareklibra
force-pushed
the
allignWithDNS1123
branch
from
01ca506
to
f68b07a
Compare
atiratree
suggested changes
Sep 10, 2019
|
|
||
| // starts with alphaNum | ||
| if (!str.charAt(0).match(alphanumericRegex)) { | ||
| return alignWithDNS1123(str.slice(1)); |
There was a problem hiding this comment.
this can be done much easier without a recursion
str.replace(/^[^a-zA-Z0-9]*/, '').replace(/[^a-zA-Z0-9]*$/, '')There was a problem hiding this comment.
sure, but I like recursion :-)
I can change it.
| /** | ||
| * Based on V2V Provider Pod manifest.yaml | ||
| */ | ||
|
|
||
| const MAX_LEN = 30; | ||
|
|
||
| // TODO: this needs to be improved to conform validations.js::validateDNS1123SubdomainValue() | ||
| const alignWithDNS1123 = str => { |
There was a problem hiding this comment.
can we rename it to trimAccordingToDNS1123 ?
There was a problem hiding this comment.
My intention is to further improve this method to fully conform DNS 1123, not just start and end. This first version was meant as a quick fix to unblock testing immediately. So it makes sense to keep the name as it is.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.