This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Integrated top consumer card for storage dashboard #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 12, 2019
rawagner
approved these changes
Apr 12, 2019
gnehapk
force-pushed
the
storage-top-consumer
branch
3 times, most recently
from
1bc6afa
to
31a460d
Compare
|
@rawagner @mareklibra I have amended the PR. Please review. |
atiratree
suggested changes
Apr 12, 2019
| @@ -180,6 +201,7 @@ export class StorageOverview extends React.Component { | |||
| }, | |||
| ...utilizationData, | |||
| alertsResponse, | |||
| ...topConsumersData, | |||
There was a problem hiding this comment.
please do not send such generic props to the consumer. i.e. stats and loaded
gnehapk
force-pushed
the
storage-top-consumer
branch
from
31a460d
to
78f55ce
Compare
|
Incorporated the changes. @rawagner @suomiy @mareklibra Please review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: kubevirt/web-ui-components#349