Vnc console #36
Vnc console #36
Conversation
|
PR deployed on my upshift: Please note, this is environment is used for development and can be broken any time in favor of other tasks. Please contact me in such case. |
|
@lizsurette, can you please have a look at this PR? |
|
|
|
LGTM. Do we want to push yarn.lock too ? |
Reuses VncConsole from pf-react.
|
@rawagner , good point. The |
|
@mareklibra This is looking very nice! I think it works really well in the Consoles tab. A few questions for you... 1 - This is SUPER nit picky, but I don't think we need the thin line at the top of the console output area. 2 - Would it be possible to add a label on the left to let the user know which console they are viewing? I think this would be especially nice once we have a dropdown to access multiple different consoles (if available). I'll attach a screenshot of what I'm talking about :) 3 - How about allowing the user to disconnect? Also, see screenshot. 4 - Are there other options we want to expose from the Send Key menu?
|
Text "Console: VNC" is rendered on top of the VncCOnsole component. Once design of console componenents is stabilized in pf-react, esp. around the ConsolleSwitcher component, this change will be moved to pf-react.
|
@lizsurette , thanks for the review.
Done. The "line" is the border rendered by
Done. The screenshot suggests placing it "close" to the console component, means at the same row as the toolbar actions). Looks nice this way but the position is already reserved for "status" information (see screenshot bellow). For now, the console-type-text is rendered one row above, leaving space for potential status information.
I can add it for consistency, but technically it makes probably no sense. This is console for the VNC protocol, not the Serial one. The connection is "hijacked" by a later one, when connected in parallel. The console is disconected when the view (i.e. In case of Serial console, this button would make sense - as another user can't "hijack" the connection easily. Anyway, such a change should go to pf-react. So let's include either resolution to the design there, please. 4 - Are there other options we want to expose from the Send Key menu? Not at this moment. I'm not aware of any kubevirt/openshift specifics in that matter, so I would add any useful shortcuts directly to pf-react's component directly. Unfortunately, the already identified ones will not make it to the build for tomorrow. Can we resolve that independently of this PR, please? |
|
|
|
@mareklibra I think this looks great for a first pass. Glad it was merged :) I will follow up with a small issue if I think of a good way to combine the status and console selection! |
|
Dear @mareklibra , Ask you a question. How to use novnc to connect vm created by kubevirt? |
In-browser access to VNC console of a VM is added.
Works fine but UXD needs to be reviewed, e.g. resizing of the console or its positioning in the UI in general.
At the time of posting this PR, it's accessible via
Consolestab underVirtualMachinepage, no matter it's related toVirtualMachineInstance.I did some cleaning of references as part of this PR too.
package.jsonchanges once Introduce kubevirt/{package.json|yarn.lock} #39 gets in