Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

added VMs dropdown in top consumers card #397

Merged
merged 1 commit into from
Jun 18, 2019
Merged

added VMs dropdown in top consumers card #397

merged 1 commit into from
Jun 18, 2019

Conversation

afreen23
Copy link

@afreen23 afreen23 changed the title added VMs dropdown in top consumers card [WIP] added VMs dropdown in top consumers card May 27, 2019
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2019
@afreen23
Copy link
Author

afreen23 commented May 28, 2019 •
edited
Loading

@mareklibra @rawagner @suomiy .... Can you guys help in providing the query for VMs...??

@atiratree
Copy link

Sorry don't really know + no prometheus atm.

The query should be only about the vm disks, right?
Another approach (just for the requested storage) could be to parse the requested capacity from vm definitions or from the pvcs.

@cloudbehl
Copy link

@suomiy The storage requested capacity can be found from the kubelet metrics but the what exactly we are looking at is the labels that define this storage is provided to VM. So we can calculate on basis of that.

@afreen23 @rawagner @mareklibra ^^

@kubevirt-bot kubevirt-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS labels May 31, 2019
@afreen23 afreen23 changed the title [WIP] added VMs dropdown in top consumers card added VMs dropdown in top consumers card Jun 17, 2019
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2019
@rawagner rawagner merged commit 2536d55 into kubevirt:master Jun 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atiratree atiratree atiratree left review comments

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@afreen23 @atiratree @cloudbehl @rawagner @kubevirt-bot