-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mvp #5
feat: mvp #5
Conversation
16887c7
to
677f0e5
Compare
fd47fb4
to
fb9173e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats, that quite an achievement! 👏
I left some minor notes, but I think this is good to be merged and released
fb9173e
to
b916015
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, congrats :).
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
1b1afde
to
d387269
Compare
Co-authored-by: José Guilherme Vanz <jvanz@jvanz.com> Signed-off-by: Fabrizio Sestito <fabrizio.sestito@suse.com>
867c41d
to
1eb26aa
Compare
LGTM, thanks for having implemented also Ship it! 🚀 |
Description
This is the MVP of a policy that can run CEL expression.
It accepts
variables
andvalidations
with the same syntax as the ValidatingAdmissionPolicy Kubernetes resource.It acts as a DSL, meaning that creating new policies is possible by configuring new settings and it does not need compilation or wasm toolkit.
The policy requires context-aware capabilities since it needs to get the namespace object of the request to populate the
namespaceObject
variable.Test
Settings validation unit tests are adapted from the Kubernetes codebase.
Furthermore, Validation unit tests and e2e tests are added.
Additional Information
Tradeoff
At the moment the policy does not support:
namespace object
andrequest
variables: waiting for this PR to be merged: ext.NativeTypes: Recursively add sub-types google/cel-go#892 so we can bind our k8s-objects to the CEL environment as types