remove named booleans on cardinality comparisons (#44)

kubikowski · Oct 28, 2022 · 3de18d9 · 3de18d9
1 parent e6460a1
commit 3de18d9
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 20 deletions.
diff --git a/src/comparisons/equivalence.function.ts b/src/comparisons/equivalence.function.ts
@@ -18,10 +18,7 @@ export function equivalence<T, S extends ReadonlySet<T>>(...sets: S[]): boolean
 
 	const cardinalities = sets.map(set => set.size);
 	const primaryCardinality = cardinalities.shift()!;
-	const allSetsHaveEqualCardinalities = cardinalities
-		.every(cardinality => cardinality === primaryCardinality);
-
-	if (!allSetsHaveEqualCardinalities) {
+	if (!cardinalities.every(cardinality => cardinality === primaryCardinality)) {
 		return false;
 	}
 

diff --git a/src/comparisons/proper-subset.function.ts b/src/comparisons/proper-subset.function.ts
@@ -18,10 +18,7 @@ export function properSubset<T, S extends ReadonlySet<T>>(...sets: S[]): boolean
 
 	const cardinalities = sets.map(set => set.size);
 	const primaryCardinality = cardinalities.shift()!;
-	const allSetsHaveGreaterCardinalities = cardinalities
-		.every(cardinality => cardinality > primaryCardinality);
-
-	if (!allSetsHaveGreaterCardinalities) {
+	if (!cardinalities.every(cardinality => cardinality > primaryCardinality)) {
 		return false;
 	}
 

diff --git a/src/comparisons/proper-superset.function.ts b/src/comparisons/proper-superset.function.ts
@@ -18,10 +18,7 @@ export function properSuperset<T, S extends ReadonlySet<T>>(...sets: S[]): boole
 
 	const cardinalities = sets.map(set => set.size);
 	const primaryCardinality = cardinalities.shift()!;
-	const allSetsHaveLesserCardinalities = cardinalities
-		.every(cardinality => cardinality < primaryCardinality);
-
-	if (!allSetsHaveLesserCardinalities) {
+	if (!cardinalities.every(cardinality => cardinality < primaryCardinality)) {
 		return false;
 	}
 

diff --git a/src/comparisons/subset.function.ts b/src/comparisons/subset.function.ts
@@ -17,10 +17,7 @@ export function subset<T, S extends ReadonlySet<T>>(...sets: S[]): boolean {
 
 	const cardinalities = sets.map(set => set.size);
 	const primaryCardinality = cardinalities.shift()!;
-	const allSetsHaveGreaterCardinalities = cardinalities
-		.every(cardinality => cardinality >= primaryCardinality);
-
-	if (!allSetsHaveGreaterCardinalities) {
+	if (!cardinalities.every(cardinality => cardinality >= primaryCardinality)) {
 		return false;
 	}
 

diff --git a/src/comparisons/superset.function.ts b/src/comparisons/superset.function.ts
@@ -19,10 +19,7 @@ export function superset<T, S extends ReadonlySet<T>>(...sets: S[]): boolean {
 
 	const cardinalities = sets.map(set => set.size);
 	const primaryCardinality = cardinalities.shift()!;
-	const allSetsHaveLesserCardinalities = cardinalities
-		.every(cardinality => cardinality <= primaryCardinality);
-
-	if (!allSetsHaveLesserCardinalities) {
+	if (!cardinalities.every(cardinality => cardinality <= primaryCardinality)) {
 		return false;
 	}