refactored funcitons to use sets.shift()
& for .. of
#43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legibility
I personally find that the resulting code is more legible, using
sets.shift()
in conjunction withfor (const set of sets)
.As an aside, this code style also removed all necessary usages of nullish coalescing.
Performance
Moreover, the refactored code resulted in an overall performance improvement of ~11% overall. This is generally due to the fact that we are not fetching
sets[index]
in each loop iteration, in favor of a pre-cachedconst set
.Testing Notes:
[original] raw data:
[rewrite] raw data:
[performance improvement] raw data: