Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improved
xor
performance:Added a preface to
xor
, which compares elements in the first 2 sets to create the initialresultSet
, and the initialduplicates
. Additionally, split implementations of each loop into 2 branches, one which adds elements toduplicates
and one which does not.This implementation saves significant time at scale by not adding elements to the
duplicates
set on the final set comparison. Indeed, for thexor
of only 2 sets: no elements whatsoever are added toduplicates
. And there is no time wasted adding elements to theresultSet
which are immediately removed, on the first comparison.The scale tests show that when taking the
xor
of 2 sets, we see a performance improvement of anywhere from ~30 to ~70%. And for 3 or more sets, we still see improvements of ~10 to ~30%.[original] raw data:
[refactor] raw data:
[performance improvement] raw data: