-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid polluting global include and link dirs #20
Commits on Nov 24, 2020
-
Avoid polluting global include and link dirs
The use of include_directories and link_directories pollutes global include and link directories. This change adds IMPORTED targets using the external projects and then links the funchook targets against them. This also avoids issues seen where captone fails to be found at link time "error: ld returned 1 exit status cannot find -lcapstone" when making use of certain toolchain files.
Configuration menu - View commit details
-
Copy full SHA for f0a8b69 - Browse repository at this point
Copy the full SHA f0a8b69View commit details
Commits on Nov 25, 2020
-
INTERFACE_INCLUDE_DIRECTORIES does not allow non-existent directories so ensure the directory is valid using file(MAKE_DIRECTORY). See https://gitlab.kitware.com/cmake/cmake/-/issues/15052 for details.
James Rumble committedNov 25, 2020 Configuration menu - View commit details
-
Copy full SHA for 97297e2 - Browse repository at this point
Copy the full SHA 97297e2View commit details
Commits on Nov 26, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1b85b39 - Browse repository at this point
Copy the full SHA 1b85b39View commit details -
Install captone to match zydis behaviour
The capstone target was previously being setup using ExternalProject_Get_Property however installing the external project and using the generic include/lib directories solves issues with config based generators.
Configuration menu - View commit details
-
Copy full SHA for 8ecd7f9 - Browse repository at this point
Copy the full SHA 8ecd7f9View commit details -
Use ${CMAKE_INSTALL_LIBDIR} instead of hardcoded lib directory
GNUInstallDirs may not always output to lib and may instead output to lib or lib64 or lib/<multiarch-tuple> on Debian.
Configuration menu - View commit details
-
Copy full SHA for d047338 - Browse repository at this point
Copy the full SHA d047338View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fa55a3 - Browse repository at this point
Copy the full SHA 8fa55a3View commit details -
Include GNUInstallDirs after project definition.
Avoid "Unable to determine default CMAKE_INSTALL_LIBDIR directory because no target architecture is known. Please enable at least one language before including GNUInstallDirs."
Configuration menu - View commit details
-
Copy full SHA for 8c3786f - Browse repository at this point
Copy the full SHA 8c3786fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5fc944 - Browse repository at this point
Copy the full SHA a5fc944View commit details -
Zydis includes GNUInstallDirs prior to language being enabled
Tag 3.1.0 of Zydis includes GNUInstallDirs prior to a language being enabled meaning its CMAKE_INSTALL_LIBDIR will always result in lib rather than its correct lib/lib64 variant. Note that Zydis master branch has fixed this issue.
Configuration menu - View commit details
-
Copy full SHA for 23f97d3 - Browse repository at this point
Copy the full SHA 23f97d3View commit details