Skip to content
This repository has been archived by the owner on Jan 21, 2023. It is now read-only.

Update html5ever to 0.20.0 #38

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Update html5ever to 0.20.0 #38

merged 1 commit into from
Sep 27, 2017

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Sep 27, 2017

Needed by rust-lang/rust#44884. html5ever 0.18.0 depends on tendril 0.3.1 which exhibits an undefined behavior by accessing a cell in a packed struct. This has been fixed in the latest version.

Unresolved: I'm not sure what to put into parser::Sink::append_based_on_parent_node.

@jdm
Copy link
Contributor

jdm commented Sep 27, 2017

You can duplicate the implementation that exists here.

@SimonSapin SimonSapin merged commit 1be51d4 into kuchiki-rs:master Sep 27, 2017
@SimonSapin
Copy link
Collaborator

Thanks. Published https://crates.io/crates/kuchiki/0.6.0

@kennytm kennytm deleted the update-dep branch September 27, 2017 14:06
arielb1 added a commit to arielb1/rust that referenced this pull request Oct 2, 2017
This is required because the old version depended on tendril 0.3.1,
which used `repr(packed)` incorrectly - see
kuchiki-rs/kuchiki#38
arielb1 added a commit to arielb1/rust that referenced this pull request Nov 23, 2017
This is required because the old version depended on tendril 0.3.1,
which used `repr(packed)` incorrectly - see
kuchiki-rs/kuchiki#38
arielb1 added a commit to arielb1/rust that referenced this pull request Nov 26, 2017
This is required because the old version depended on tendril 0.3.1,
which used `repr(packed)` incorrectly - see
kuchiki-rs/kuchiki#38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants