-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add ARM64 Support #1488
[Feature] Add ARM64 Support #1488
Conversation
00eb447
to
d3a77fa
Compare
I found that on lower powered ARM machines when trying to build Kudo a longer timeout was needed to complete. Signed-off-by: Shane Utt <shaneutt@linux.com>
Signed-off-by: Shane Utt <shaneutt@linux.com>
d3a77fa
to
c9523ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition, just have small comments before approving.
One drawback is that the ARM64 binaries aren't tested, but we already have the same situation with the Windows binaries, so I'm okay with that.
When you say tested, do you mean CI tests? I think that in the last community meeting it was found that github actions should support ARM based testing if that's something worth setting up here? cc @gerred 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please revert the changes in test/run_tests.sh
to get the CI green again.
4aacf9a
to
a48036a
Compare
Signed-off-by: Shane Utt <shaneutt@linux.com>
Signed-off-by: Shane Utt <shaneutt@linux.com>
What this PR does / why we need it:
The purpose of this PR is to add multi-platform builds and pushes from the
Makefile
and add support for the ARM64 platform to the Kudo controller.I tested these changes locally on both an amd64 and arm64 machine the results of my testing are the following repository for your review:
https://hub.docker.com/repository/docker/armk8s/kudo-controller
Fixes #1447