Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add ARM64 Support #1488

Merged
merged 4 commits into from
May 5, 2020

Conversation

shaneutt
Copy link
Contributor

@shaneutt shaneutt commented May 2, 2020

What this PR does / why we need it:

The purpose of this PR is to add multi-platform builds and pushes from the Makefile and add support for the ARM64 platform to the Kudo controller.

I tested these changes locally on both an amd64 and arm64 machine the results of my testing are the following repository for your review:

https://hub.docker.com/repository/docker/armk8s/kudo-controller

Fixes #1447

@shaneutt shaneutt force-pushed the shaneutt/add-arm64-support branch from 00eb447 to d3a77fa Compare May 2, 2020 02:59
shaneutt added 2 commits May 1, 2020 23:00
I found that on lower powered ARM machines when trying to build
Kudo a longer timeout was needed to complete.

Signed-off-by: Shane Utt <shaneutt@linux.com>
Signed-off-by: Shane Utt <shaneutt@linux.com>
@shaneutt shaneutt force-pushed the shaneutt/add-arm64-support branch from d3a77fa to c9523ed Compare May 3, 2020 20:23
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition, just have small comments before approving.
One drawback is that the ARM64 binaries aren't tested, but we already have the same situation with the Windows binaries, so I'm okay with that.

Dockerfile.arm64 Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@shaneutt
Copy link
Contributor Author

shaneutt commented May 4, 2020

This is a great addition, just have small comments before approving.
One drawback is that the ARM64 binaries aren't tested, but we already have the same situation with the Windows binaries, so I'm okay with that.

When you say tested, do you mean CI tests? I think that in the last community meeting it was found that github actions should support ARM based testing if that's something worth setting up here? cc @gerred 🤔

@shaneutt shaneutt requested a review from nfnt May 4, 2020 13:25
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please revert the changes in test/run_tests.sh to get the CI green again.

test/run_tests.sh Outdated Show resolved Hide resolved
@shaneutt shaneutt force-pushed the shaneutt/add-arm64-support branch from 4aacf9a to a48036a Compare May 4, 2020 14:13
shaneutt and others added 2 commits May 4, 2020 10:14
Signed-off-by: Shane Utt <shaneutt@linux.com>
Signed-off-by: Shane Utt <shaneutt@linux.com>
@nfnt nfnt merged commit 63c653a into kudobuilder:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARM Support
3 participants