Address breaking change in satori/go.uuid #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TakatoshiMaeda plz review it 👀 🙏 |
takatoshi-maeda
requested changes
Aug 13, 2018
handler_sandbox.go
Outdated
| @@ -17,7 +17,8 @@ func UploadImageToSandboxHandler(w http.ResponseWriter, r *http.Request, ps http | |||
|
|
|||
| r.ParseMultipartForm(0) | |||
|
|
|||
| imageId := uuid.NewV4().String() | |||
| uuidObject, _ := uuid.NewV4() | |||
There was a problem hiding this comment.
If an error occurs, can we continue the processing after this?
It seems necessary to properly handle the error.
How about this way?
imageId, err := uuid.NewV4()
if err != nil {
RespondInternalServerError(w, err)
return
}
added 2 commits
August 13, 2018 18:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error caused by breaking changes in satori/go.uuid package.
ref: satori/go.uuid#66
I've faced the following error when I tried to build Kinu with latest commit hash.