Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert @angular/material imports to make them tree shakable #44

Closed
thienedits opened this issue Aug 27, 2018 · 2 comments
Closed

Convert @angular/material imports to make them tree shakable #44

thienedits opened this issue Aug 27, 2018 · 2 comments
Assignees
@kuhnroyal
Labels
enhancement

Comments

@thienedits
Copy link

Please look at the material2 issue and specifically the comment from the link below:

angular/components#4137 (comment)
kuhnroyal pushed a commit that referenced this issue Dec 14, 2018
@kuhnroyal
chore(#44): Analyze the sample app bundle
208bb29 
Signed-off-by: Peter Leibiger <kuhnroyal@gmail.com>
kuhnroyal pushed a commit that referenced this issue Dec 14, 2018
@kuhnroyal
feat(#44): Import specific modules of @angular/material
41971e9 
Signed-off-by: Peter Leibiger <kuhnroyal@gmail.com>
kuhnroyal pushed a commit that referenced this issue Dec 14, 2018
@kuhnroyal
feat(#44): Import specific modules of @angular/material
0968922 
* ban '@angular/material' import

Signed-off-by: Peter Leibiger <kuhnroyal@gmail.com>
@kuhnroyal kuhnroyal self-assigned this Dec 14, 2018
@kuhnroyal
Copy link
Owner

I am not seeing any difference in the bundle size of the sample app. Tree-shaking works either way but I guess it doesn't hurt.
bundle_after

kuhnroyal pushed a commit that referenced this issue Dec 16, 2018
@kuhnroyal
feat(#44): Import specific modules of @angular/material
a9de440 
* ban '@angular/material' import

Signed-off-by: Peter Leibiger <kuhnroyal@gmail.com>
@bbortt
Copy link
Collaborator

bbortt commented Oct 30, 2019

This is a "must have" withing angular/v8+, I think. was partially done in #73 . will take a look at and merge #57 anyways.

bbortt added a commit that referenced this issue Oct 30, 2019
@bbortt
Merge remote-tracking branch 'origin/master' into feature/#44-tree-sh…
5ccab24 
…aking
bbortt added a commit that referenced this issue Oct 30, 2019
@bbortt
Merge remote-tracking branch 'origin/master' into feature/#44-tree-sh…
bf3b221 
…aking
bbortt added a commit that referenced this issue Oct 30, 2019
@bbortt
Merge pull request #57 from kuhnroyal/feature/#44-tree-shaking
0e51050 
Feature/#44 tree shaking
@bbortt bbortt closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuhnroyal kuhnroyal

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kuhnroyal @thienedits @bbortt