Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode in progress. #101

Merged
merged 7 commits into from
Sep 21, 2020
Merged

Conversation

vivek32ta
Copy link
Contributor

Hi,

I'm still working on this. But I've done a couple of changes till now including adding a toggle to dark mode on the top right corner. But the change is limited to only the body div. And also when you navigate to a different page, the mode switches back to default, I'll fix both these issues. If you see anymore, or if you want any changes in these, feel free to let me know.

Thanks for your help with yarn. :)

Best,
Vivek

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2020

💥 No Changeset

Latest commit: fa42db7

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kuldeepkeshwar/filbert-js/oej5xu5t4
✅ Preview: https://filbert-js-git-fork-vivek32ta-dark-mode.kuldeepkeshwar.vercel.app

@kuldeepkeshwar
Copy link
Owner

@vivek32ta thanks for the pull request.
Couple of points I have in mind.

  • To preserve mode value b/w navigation, we can persist the state in local storage & keep it in sync(read/write) b/w navigations.
  • Respect User's color-scheme, this can be done using media query.

But the change is limited to only the body div

^ is because Global component is not theme aware. have opened an issue #102 for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants