Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transformer): add deepUnmock to hoist method list #1372

Merged
merged 3 commits into from
Feb 5, 2020
Merged

fix(transformer): add deepUnmock to hoist method list #1372

merged 3 commits into from
Feb 5, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Feb 5, 2020

  • Add deepUnmock to hoist method list
  • Improve hoist codes
  • Improve unit tests and e2e tests

Closes #1088, #1098

Thanks @tonyhallett for the solution

@ahnpnl ahnpnl requested a review from kulshekhar February 5, 2020 12:51
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3955

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 90.468%
Totals Coverage Status
Change from base Build 3953: 0.01%
Covered Lines: 1067
Relevant Lines: 1123
💛 - Coveralls

@ahnpnl ahnpnl merged commit 0fbbc00 into kulshekhar:master Feb 5, 2020
@ahnpnl ahnpnl deleted the fix-hoisting branch February 5, 2020 15:11
@ahnpnl ahnpnl mentioned this pull request Feb 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ts-jest does not hoist variables beginning with mock
3 participants
@ahnpnl @coveralls @kulshekhar