Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): make projectReferences work with LanguageService #1541

Merged
merged 4 commits into from
Apr 19, 2020
Merged

fix(compiler): make projectReferences work with LanguageService #1541

merged 4 commits into from
Apr 19, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 18, 2020 •
edited
Loading

Summary

Finish the remaining the work of #1527 , this PR makes projectReferences work with LanguageService, close #766

Caveat:
It is required to build the project first with tsc -b to have the compiled files ready. Including tsc -b will be done in #1159

Test plan

  • Adjust external repos tests to include one composite project to test with isolatedModules: true and one composite project to test with isolatedModules: false.
  • Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner April 18, 2020 22:07
@coveralls
Copy link

coveralls commented Apr 19, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 4454

  • 32 of 32 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 92.835%
Totals Coverage Status
Change from base Build 4453: 0.02%
Covered Lines: 1172
Relevant Lines: 1209
💛 - Coveralls

@ahnpnl ahnpnl merged commit 3e8efbe into kulshekhar:master Apr 19, 2020
@ahnpnl ahnpnl deleted the project-references-part-2 branch April 19, 2020 14:46
@ahnpnl ahnpnl mentioned this pull request Apr 20, 2020
Closed
@ahnpnl ahnpnl mentioned this pull request Apr 30, 2020
Open
@ahnpnl ahnpnl mentioned this pull request May 8, 2020
Merged
2 tasks
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler options not working as expected when using project references
3 participants
@ahnpnl @coveralls @kulshekhar