Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove resolve dependency #1563

Merged
merged 1 commit into from
Apr 25, 2020
Merged

chore: remove resolve dependency #1563

merged 1 commit into from
Apr 25, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 24, 2020

Summary

Remove resolve dependency since it's not in used by the codes

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner April 24, 2020 15:11
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4532

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.813%

Totals Coverage Status
Change from base Build 4524: 0.0%
Covered Lines: 1054
Relevant Lines: 1089

💛 - Coveralls

@ahnpnl ahnpnl merged commit 93348ac into 25.x.x Apr 25, 2020
@ahnpnl ahnpnl deleted the remove-resolve branch April 25, 2020 06:05
ahnpnl added a commit that referenced this pull request Apr 27, 2020
ahnpnl added a commit that referenced this pull request Apr 28, 2020
ahnpnl added a commit that referenced this pull request Apr 29, 2020
ahnpnl added a commit that referenced this pull request Apr 29, 2020
ahnpnl added a commit that referenced this pull request Apr 30, 2020
ahnpnl added a commit that referenced this pull request May 1, 2020
ahnpnl added a commit that referenced this pull request May 1, 2020
ahnpnl added a commit that referenced this pull request May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants