Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly invalidate cache key when transform options change #288

Merged
merged 2 commits into from
Aug 5, 2017

Conversation

jwbay
Copy link
Contributor

@jwbay jwbay commented Aug 3, 2017

Transform cache invalidation for coverage seems to implicitly rely on instrumentation changing some value in tsconfig. Besides making the invalidation more explicit, since the last value passed to getCacheKey is an options bag, ts-jest can insulate itself from new transform options being added in the future that should also bust the cache by just stringifying the object. I'm trying to get a change into jest that adds mapCoverage to the options here, for example.

@kulshekhar
Copy link
Owner

@jwbay thanks for the PR :)

Can you also update the authors file with your name?

This looks good to me and can be merged in after one other collaborator okays it.

@kulshekhar kulshekhar merged commit 81b5307 into kulshekhar:master Aug 5, 2017
@jwbay jwbay deleted the transform-cache branch August 5, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants