Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve examples folder #4083

Merged
merged 2 commits into from
Apr 9, 2023
Merged

Improve examples folder #4083

merged 2 commits into from
Apr 9, 2023

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 3, 2023

Summary

See individual commits

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4596657275

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 95.842%

Totals Coverage Status
Change from base Build 4595719534: 0.009%
Covered Lines: 4055
Relevant Lines: 4154

💛 - Coveralls

@ahnpnl ahnpnl marked this pull request as ready for review April 3, 2023 12:40
@ahnpnl ahnpnl requested a review from kulshekhar as a code owner April 3, 2023 12:40
@mike-lischke
Copy link

Very nice! I wonder why you now spread the preset in the config. For me it works fine to set the preset field and have the transform field set to transform ts with ESM.

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Apr 3, 2023

The purpose is moving away from using preset key to avoid conflicting when using together with transform. Even though we have put a warning in documentation but still many users often run into that mistake.

Making example repos config to be clearer is the first step.

@mike-lischke
Copy link

But isn't the preset key the main configuration switch in Jest? Somehow that seems to be counter productive. Wouldn't it be better to check if both are used and print an error in the terminal, instead?

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Apr 3, 2023

That would be the 2nd step.

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Apr 9, 2023

Ping @kulshekhar

@ahnpnl ahnpnl merged commit 16d4206 into kulshekhar:main Apr 9, 2023
@ahnpnl ahnpnl deleted the infra/upgrade-ts-5-example branch April 9, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants