Skip to content

Commit

Permalink
fix: make targetRef required (#5593)
Browse files Browse the repository at this point in the history 
Signed-off-by: AyushSenapati <a.p.senapati008@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
  • Loading branch information
@AyushSenapati @michaelbeaumont
AyushSenapati and michaelbeaumont authored Jan 9, 2023
1 parent 04e12aa commit 5a5969f
Show file tree
Hide file tree
Showing 42 changed files with 361 additions and 25 deletions.
36 changes: 36 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -799,8 +799,12 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
required:
- targetRef
type: object
type: object
served: true
Expand Down Expand Up @@ -998,6 +1002,8 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
targetRef:
Expand Down Expand Up @@ -1029,6 +1035,8 @@ spec:
Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: object
served: true
Expand Down Expand Up @@ -1270,8 +1278,12 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
required:
- targetRef
type: object
type: object
served: true
Expand Down Expand Up @@ -1395,6 +1407,8 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
targetRef:
Expand Down Expand Up @@ -1507,8 +1521,12 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
required:
- targetRef
type: object
type: object
served: true
Expand Down Expand Up @@ -1689,6 +1707,8 @@ spec:
Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: object
served: true
Expand Down Expand Up @@ -1779,6 +1799,8 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
targetRef:
Expand Down Expand Up @@ -1810,6 +1832,8 @@ spec:
Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: object
served: true
Expand Down Expand Up @@ -2895,6 +2919,8 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
targetRef:
Expand Down Expand Up @@ -3023,8 +3049,12 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
required:
- targetRef
type: object
type: object
served: true
Expand Down Expand Up @@ -3353,6 +3383,8 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
targetRef:
Expand Down Expand Up @@ -3669,8 +3701,12 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
required:
- targetRef
type: object
type: object
served: true
Expand Down
36 changes: 36 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.gateway-api-present-not-enabled.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -799,8 +799,12 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
required:
- targetRef
type: object
type: object
served: true
Expand Down Expand Up @@ -998,6 +1002,8 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
targetRef:
Expand Down Expand Up @@ -1029,6 +1035,8 @@ spec:
Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: object
served: true
Expand Down Expand Up @@ -1270,8 +1278,12 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
required:
- targetRef
type: object
type: object
served: true
Expand Down Expand Up @@ -1395,6 +1407,8 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
targetRef:
Expand Down Expand Up @@ -1507,8 +1521,12 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
required:
- targetRef
type: object
type: object
served: true
Expand Down Expand Up @@ -1689,6 +1707,8 @@ spec:
Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: object
served: true
Expand Down Expand Up @@ -1779,6 +1799,8 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
targetRef:
Expand Down Expand Up @@ -1810,6 +1832,8 @@ spec:
Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: object
served: true
Expand Down Expand Up @@ -2895,6 +2919,8 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
targetRef:
Expand Down Expand Up @@ -3023,8 +3049,12 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
required:
- targetRef
type: object
type: object
served: true
Expand Down Expand Up @@ -3353,6 +3383,8 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
targetRef:
Expand Down Expand Up @@ -3669,8 +3701,12 @@ spec:
tags. Can only be used with kinds `MeshSubset` and `MeshServiceSubset`
type: object
type: object
required:
- targetRef
type: object
type: array
required:
- targetRef
type: object
type: object
served: true
Expand Down
Loading

0 comments on commit 5a5969f

Please sign in to comment.