Merge branch 'master' into feat/serviceMap

.golangci.yml

@@ -33,6 +33,10 @@ linters-settings:
       alias: mesh_proto
     - pkg: github.com/kumahq/kuma/pkg/util/proto
       alias: util_proto
+  misspell:
+    locale: US
+    ignore-words:
+    - cancelled # US English should be "canceled", but this is in the Retry API, so we can't change it.
 
 issues:
   fix: true

api/Makefile

@@ -163,17 +163,14 @@ clean: ## Remove generated files
 	find . -name '*.pb.go' -delete
 	find . -name '*.pb.validate.go' -delete
 
-generate: clean protoc/mesh protoc/mesh/v1alpha1 protoc/observability/v1alpha1 protoc/observability/v1 protoc/system/v1alpha1 ## Process .proto definitions
+generate: clean protoc/mesh protoc/mesh/v1alpha1 protoc/observability/v1 protoc/system/v1alpha1 ## Process .proto definitions
 
 protoc/mesh:
 	$(PROTOC_GO) mesh/*.proto
 
 protoc/mesh/v1alpha1:
 	$(PROTOC_GO) mesh/v1alpha1/*.proto
 
-protoc/observability/v1alpha1:
-	$(PROTOC_GO) observability/v1alpha1/*.proto
-
 protoc/observability/v1:
 	$(PROTOC_GO) observability/v1/*.proto
 

api/mesh/v1alpha1/circuit_breaker.proto

@@ -26,10 +26,10 @@ message CircuitBreaker {
   option (kuma.mesh.resource).ws.name = "circuit-breaker";
 
   // List of selectors to match dataplanes that are sources of traffic.
-  repeated Selector sources = 1;
+  repeated Selector sources = 1 [ (doc.required) = true ];
 
   // List of selectors to match services that are destinations of traffic.
-  repeated Selector destinations = 2;
+  repeated Selector destinations = 2 [ (doc.required) = true ];
 
   message Conf {
     // Time interval between ejection analysis sweeps
@@ -102,5 +102,5 @@ message CircuitBreaker {
     Thresholds thresholds = 6;
   }
 
-  Conf conf = 3;
+  Conf conf = 3 [ (doc.required) = true ];
 }

api/mesh/v1alpha1/externalservice.proto

@@ -29,7 +29,7 @@ message ExternalService {
   // Networking describes the properties of the external service connectivity
   message Networking {
     // Address of the external service
-    string address = 1;
+    string address = 1 [ (doc.required) = true ];
 
     // TLS
     message TLS {
@@ -59,9 +59,10 @@ message ExternalService {
     TLS tls = 2;
   }
 
-  Networking networking = 1;
+  Networking networking = 1 [ (doc.required) = true ];
 
   // Tags associated with the external service,
   // e.g. kuma.io/service=web, kuma.io/protocol, version=1.0.
-  map<string, string> tags = 2 [ (validate.rules).map.min_pairs = 1 ];
+  map<string, string> tags = 2
+      [ (validate.rules).map.min_pairs = 1, (doc.required) = true ];
 }