Skip to content

Commit

Permalink
feat(kumactl): add --api-timeout flag
Browse files Browse the repository at this point in the history
tests were flaky because we were modifying a global variable.
Extracted this global var in a configuration parameter as it may be
useful anyway

Signed-off-by: Charly Molter <charly.molter@konghq.com>

Actually do api-timeout for the whole kumactl

Signed-off-by: Charly Molter <charly.molter@konghq.com>
  • Loading branch information
lahabana committed Jan 19, 2022
1 parent 3628ff7 commit 60fe939
Show file tree
Hide file tree
Showing 96 changed files with 644 additions and 401 deletions.
3 changes: 2 additions & 1 deletion app/kumactl/cmd/apply/apply_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"path/filepath"
"strconv"
"strings"
"time"

. "github.com/onsi/ginkgo"
. "github.com/onsi/ginkgo/extensions/table"
Expand Down Expand Up @@ -42,7 +43,7 @@ var _ = Describe("kumactl apply", func() {
rootCtx = &kumactl_cmd.RootContext{
Runtime: kumactl_cmd.RootRuntime{
Registry: registry.Global(),
NewBaseAPIServerClient: func(server *config_proto.ControlPlaneCoordinates_ApiServer) (util_http.Client, error) {
NewBaseAPIServerClient: func(server *config_proto.ControlPlaneCoordinates_ApiServer, _ time.Duration) (util_http.Client, error) {
return nil, nil
},
NewResourceStore: func(util_http.Client) core_store.ResourceStore {
Expand Down
Loading

0 comments on commit 60fe939

Please sign in to comment.