fix(policies): make options for policies simpler (#4722)

- We were exposing all the parameters that were introduced
for transparent back compat with old policies and resources.
As everything is meant to be standard with these new policies
it's not required to expose all this and we should have a small
API with little tweakable parameters
- make Validate a separate runtime checked method

Signed-off-by: Charly Molter <charly.molter@konghq.com>

api/mesh/options.proto

@@ -19,9 +19,6 @@ message KumaResourceOptions {
   // Name of the resource's Go package.
   string package = 4;
 
-  // Whether to generate a no-op validation function.
-  bool skip_validation = 5;
-
   // Whether to skip type registration for this resource.
   bool skip_registration = 6;
 
@@ -66,6 +63,15 @@ message KumaKdsOptions {
   bool send_to_zone = 2;
 }
 
+message KumaPolicyOptions {
+  // Whether to skip type registration for this resource.
+  bool skip_registration = 1;
+  // An optional alternative plural form if this is unset default to a standard
+  // derivation of the name
+  string plural = 2;
+}
+
 extend google.protobuf.MessageOptions {
   KumaResourceOptions resource = 43534533; // 'kuma'
+  KumaPolicyOptions policy = 43534534;     // 'kuma'
 }

api/mesh/v1alpha1/dataplane_insight.proto

@@ -14,7 +14,6 @@ message DataplaneInsight {
   option (kuma.mesh.resource).name = "DataplaneInsightResource";
   option (kuma.mesh.resource).type = "DataplaneInsight";
   option (kuma.mesh.resource).package = "mesh";
-  option (kuma.mesh.resource).skip_validation = true;
   option (kuma.mesh.resource).kds.send_to_global = true;
   option (kuma.mesh.resource).ws.name = "dataplane-insight";
   option (kuma.mesh.resource).ws.read_only = true;

api/mesh/v1alpha1/dataplane_overview.proto

@@ -16,7 +16,6 @@ message DataplaneOverview {
   option (kuma.mesh.resource).type = "DataplaneOverview";
   option (kuma.mesh.resource).package = "mesh";
   option (kuma.mesh.resource).skip_registration = true;
-  option (kuma.mesh.resource).skip_validation = true;
   option (kuma.mesh.resource).skip_kubernetes_wrappers = true;
 
   Dataplane dataplane = 1 [ (validate.rules).message.required = true ];

api/mesh/v1alpha1/mesh_insight.proto

@@ -13,7 +13,6 @@ message MeshInsight {
   option (kuma.mesh.resource).type = "MeshInsight";
   option (kuma.mesh.resource).global = true;
   option (kuma.mesh.resource).package = "mesh";
-  option (kuma.mesh.resource).skip_validation = true;
   option (kuma.mesh.resource).ws.name = "mesh-insight";
   option (kuma.mesh.resource).ws.read_only = true;
 

api/mesh/v1alpha1/service_insight.proto

@@ -11,7 +11,6 @@ message ServiceInsight {
   option (kuma.mesh.resource).name = "ServiceInsightResource";
   option (kuma.mesh.resource).type = "ServiceInsight";
   option (kuma.mesh.resource).package = "mesh";
-  option (kuma.mesh.resource).skip_validation = true;
   option (kuma.mesh.resource).kds.send_to_zone = true;
   option (kuma.mesh.resource).ws.name = "service-insight";
   option (kuma.mesh.resource).ws.read_only = true;
@@ -23,7 +22,6 @@ message ServiceInsight {
     option (kuma.mesh.resource).type = "ServiceOverview";
     option (kuma.mesh.resource).package = "mesh";
     option (kuma.mesh.resource).skip_registration = true;
-    option (kuma.mesh.resource).skip_validation = true;
     option (kuma.mesh.resource).skip_kubernetes_wrappers = true;
 
     enum Status {

api/mesh/v1alpha1/zone_ingress_insight.proto

@@ -14,7 +14,6 @@ message ZoneIngressInsight {
   option (kuma.mesh.resource).type = "ZoneIngressInsight";
   option (kuma.mesh.resource).package = "mesh";
   option (kuma.mesh.resource).global = true;
-  option (kuma.mesh.resource).skip_validation = true;
   option (kuma.mesh.resource).kds.send_to_global = true;
   option (kuma.mesh.resource).ws.name = "zone-ingress-insight";
   option (kuma.mesh.resource).ws.read_only = true;