fix(GatewayAPI): don't share HTTPRoute conditions between parentRefs

kumahq · Apr 14, 2023 · b80c33b · b80c33b
1 parent 433f90b
commit b80c33b
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/pkg/plugins/runtime/k8s/controllers/gatewayapi/http_route_controller.go b/pkg/plugins/runtime/k8s/controllers/gatewayapi/http_route_controller.go
@@ -5,6 +5,7 @@ import (
 
 	"github.com/go-logr/logr"
 	"github.com/pkg/errors"
+	"golang.org/x/exp/slices"
 	kube_core "k8s.io/api/core/v1"
 	kube_apierrs "k8s.io/apimachinery/pkg/api/errors"
 	kube_apimeta "k8s.io/apimachinery/pkg/api/meta"
@@ -119,6 +120,8 @@ func (r *HTTPRouteReconciler) gapiToKumaRoutes(
 			return nil, nil, errors.Wrapf(err, "unable to check parent ref %d", i)
 		}
 
+		refConditions := slices.Clone(routeConditions)
+
 		switch refAttachment {
 		case attachment.Unknown:
 			// We don't care about this ref
@@ -141,16 +144,16 @@ func (r *HTTPRouteReconciler) gapiToKumaRoutes(
 				reason = string(gatewayapi.RouteReasonNoMatchingParent)
 			}
 
-			if !kube_apimeta.IsStatusConditionFalse(routeConditions, string(gatewayapi.RouteConditionAccepted)) {
-				kube_apimeta.SetStatusCondition(&routeConditions, kube_meta.Condition{
+			if !kube_apimeta.IsStatusConditionFalse(refConditions, string(gatewayapi.RouteConditionAccepted)) {
+				kube_apimeta.SetStatusCondition(&refConditions, kube_meta.Condition{
 					Type:   string(gatewayapi.RouteConditionAccepted),
 					Status: kube_meta.ConditionFalse,
 					Reason: reason,
 				})
 			}
 		}
 
-		conditions[ref] = routeConditions
+		conditions[ref] = refConditions
 	}
 
 	var kumaRoute *mesh_proto.MeshGatewayRoute