chore(dns)!: remove DNS server

Now that we don't run the DNS server we don't need to have vips not overlapping between mesh. This removes this feature which greatly improves scalability when using multi-mesh Signed-off-by: Charly Molter <charly.molter@konghq.com>
kumahq · Apr 28, 2022 · f902dd7 · f902dd7
1 parent 717157e
commit f902dd7
Show file tree

Hide file tree

Showing 59 changed files with 167 additions and 1,755 deletions.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -8,6 +8,8 @@ does not have any particular instructions.
 
 ## Upcoming release
 
+The `control-plane` no longer hosts a builtin DNS server. You should always rely on the embedded DNS in the dataplane proxy and VIPs can't be used without transparent proxy.
+
 ## Upgrade to `1.6.x`
 
 ### Helm

diff --git a/app/kuma-cp/cmd/run.go b/app/kuma-cp/cmd/run.go
@@ -14,7 +14,6 @@ import (
 	"github.com/kumahq/kuma/pkg/core/bootstrap"
 	"github.com/kumahq/kuma/pkg/defaults"
 	"github.com/kumahq/kuma/pkg/diagnostics"
-	"github.com/kumahq/kuma/pkg/dns"
 	dp_server "github.com/kumahq/kuma/pkg/dp-server"
 	"github.com/kumahq/kuma/pkg/gc"
 	"github.com/kumahq/kuma/pkg/hds"
@@ -88,10 +87,6 @@ func newRunCmdWithOpts(opts kuma_cmd.RunCmdOpts) *cobra.Command {
 				runLog.Error(err, "unable to set up Monitoring Assignment server")
 				return err
 			}
-			if err := dns.Setup(rt); err != nil {
-				runLog.Error(err, "unable to set up DNS")
-				return err
-			}
 			if err := xds.Setup(rt); err != nil {
 				runLog.Error(err, "unable to set up XDS")
 				return err

diff --git a/app/kumactl/cmd/completion/testdata/bash.golden b/app/kumactl/cmd/completion/testdata/bash.golden
@@ -3679,41 +3679,6 @@ _kumactl_install_demo()
     noun_aliases=()
 }
 
-_kumactl_install_dns()
-{
-    last_command="kumactl_install_dns"
-
-    command_aliases=()
-
-    commands=()
-
-    flags=()
-    two_word_flags=()
-    local_nonpersistent_flags=()
-    flags_with_completion=()
-    flags_completion=()
-
-    flags+=("--namespace=")
-    two_word_flags+=("--namespace")
-    local_nonpersistent_flags+=("--namespace")
-    local_nonpersistent_flags+=("--namespace=")
-    flags+=("--port=")
-    two_word_flags+=("--port")
-    local_nonpersistent_flags+=("--port")
-    local_nonpersistent_flags+=("--port=")
-    flags+=("--api-timeout=")
-    two_word_flags+=("--api-timeout")
-    flags+=("--config-file=")
-    two_word_flags+=("--config-file")
-    flags+=("--log-level=")
-    two_word_flags+=("--log-level")
-    flags+=("--no-config")
-
-    must_have_one_flag=()
-    must_have_one_noun=()
-    noun_aliases=()
-}
-
 _kumactl_install_gateway_kong()
 {
     last_command="kumactl_install_gateway_kong"
@@ -4017,7 +3982,6 @@ _kumactl_install()
     commands+=("control-plane")
     commands+=("crds")
     commands+=("demo")
-    commands+=("dns")
     commands+=("gateway")
     commands+=("logging")
     commands+=("metrics")

diff --git a/app/kumactl/cmd/install/install.go b/app/kumactl/cmd/install/install.go
@@ -18,7 +18,6 @@ func NewInstallCmd(pctx *kumactl_cmd.RootContext) *cobra.Command {
 	cmd.AddCommand(newInstallCrdsCmd(&pctx.InstallCRDContext))
 	cmd.AddCommand(newInstallMetrics(pctx))
 	cmd.AddCommand(newInstallTracing(pctx))
-	cmd.AddCommand(newInstallDNS())
 	cmd.AddCommand(newInstallLogging(pctx))
 	cmd.AddCommand(newInstallDemoCmd(&pctx.InstallDemoContext))
 	cmd.AddCommand(newInstallGatewayCmd(pctx))

diff --git a/app/kumactl/cmd/install/install_dns.go b/app/kumactl/cmd/install/install_dns.go
diff --git a/app/kumactl/cmd/install/testdata/install-control-plane.cni-enabled.golden.yaml b/app/kumactl/cmd/install/testdata/install-control-plane.cni-enabled.golden.yaml
@@ -1841,8 +1841,6 @@ spec:
             - containerPort: 5682
             - containerPort: 5443
             - containerPort: 5678
-            - containerPort: 5653
-              protocol: UDP
           livenessProbe:
             httpGet:
               path: /healthy

diff --git a/app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml b/app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml
@@ -1666,8 +1666,6 @@ spec:
             - containerPort: 5682
             - containerPort: 5443
             - containerPort: 5678
-            - containerPort: 5653
-              protocol: UDP
           livenessProbe:
             httpGet:
               path: /healthy

diff --git a/app/kumactl/cmd/install/testdata/install-control-plane.override-env-vars.golden.yaml b/app/kumactl/cmd/install/testdata/install-control-plane.override-env-vars.golden.yaml
@@ -1666,8 +1666,6 @@ spec:
             - containerPort: 5682
             - containerPort: 5443
             - containerPort: 5678
-            - containerPort: 5653
-              protocol: UDP
           livenessProbe:
             httpGet:
               path: /healthy

diff --git a/app/kumactl/cmd/install/testdata/install-control-plane.overrides.golden.yaml b/app/kumactl/cmd/install/testdata/install-control-plane.overrides.golden.yaml
@@ -2090,8 +2090,6 @@ spec:
             - containerPort: 5682
             - containerPort: 5443
             - containerPort: 5678
-            - containerPort: 5653
-              protocol: UDP
           livenessProbe:
             httpGet:
               path: /healthy

diff --git a/app/kumactl/cmd/install/testdata/install-control-plane.with-egress.golden.yaml b/app/kumactl/cmd/install/testdata/install-control-plane.with-egress.golden.yaml
@@ -1695,8 +1695,6 @@ spec:
             - containerPort: 5682
             - containerPort: 5443
             - containerPort: 5678
-            - containerPort: 5653
-              protocol: UDP
           livenessProbe:
             httpGet:
               path: /healthy

diff --git a/app/kumactl/cmd/install/testdata/install-control-plane.with-helm-set.yaml b/app/kumactl/cmd/install/testdata/install-control-plane.with-helm-set.yaml
@@ -1732,8 +1732,6 @@ spec:
             - containerPort: 5682
             - containerPort: 5443
             - containerPort: 5678
-            - containerPort: 5653
-              protocol: UDP
           livenessProbe:
             httpGet:
               path: /healthy

diff --git a/app/kumactl/cmd/install/testdata/install-control-plane.with-helm-values.yaml b/app/kumactl/cmd/install/testdata/install-control-plane.with-helm-values.yaml
@@ -1666,8 +1666,6 @@ spec:
             - containerPort: 5682
             - containerPort: 5443
             - containerPort: 5678
-            - containerPort: 5653
-              protocol: UDP
           livenessProbe:
             httpGet:
               path: /healthy

diff --git a/app/kumactl/cmd/install/testdata/install-control-plane.with-ingress.golden.yaml b/app/kumactl/cmd/install/testdata/install-control-plane.with-ingress.golden.yaml
@@ -1703,8 +1703,6 @@ spec:
             - containerPort: 5682
             - containerPort: 5443
             - containerPort: 5678
-            - containerPort: 5653
-              protocol: UDP
           livenessProbe:
             httpGet:
               path: /healthy

diff --git a/app/kumactl/cmd/install/testdata/install-control-plane.zone.golden.yaml b/app/kumactl/cmd/install/testdata/install-control-plane.zone.golden.yaml
@@ -1674,8 +1674,6 @@ spec:
             - containerPort: 5682
             - containerPort: 5443
             - containerPort: 5678
-            - containerPort: 5653
-              protocol: UDP
           livenessProbe:
             httpGet:
               path: /healthy

diff --git a/deployments/charts/kuma/templates/cp-deployment.yaml b/deployments/charts/kuma/templates/cp-deployment.yaml
@@ -97,9 +97,7 @@ spec:
             - containerPort: 5443
             {{- if ne .Values.controlPlane.mode "global" }}
             - containerPort: 5678
-            - containerPort: 5653
-              protocol: UDP
-          {{- end }}
+            {{- end }}
           livenessProbe:
             httpGet:
               path: /healthy

diff --git a/docs/cmd/kuma-cp/kuma-cp.md b/docs/cmd/kuma-cp/kuma-cp.md