Make logger names consistent in the xDS server package

[jpeach]

Summary

 git grep Log.*WithName pkg/xds/
pkg/xds/bootstrap/handler.go:var log = core.Log.WithName("bootstrap")
pkg/xds/cache/cla/cache.go:     claCacheLog = core.Log.WithName("cla-cache")
pkg/xds/cache/mesh/snapshot.go:var meshCacheLog = core.Log.WithName("mesh-cache")
pkg/xds/envoy/clusters/v3/health_check_configurer.go:           core.Log.WithName("health-check-configurer").Error(
pkg/xds/generator/outbound_proxy_generator.go:var outboundLog = core.Log.WithName("outbound-proxy-generator")
pkg/xds/server/callbacks/dataplane_lifecycle.go:var lifecycleLog = core.Log.WithName("xds").WithName("dp-lifecycle")
pkg/xds/server/callbacks/dataplane_status_sink.go:var sinkLog = core.Log.WithName("xds").WithName("sink")
pkg/xds/server/callbacks/dataplane_status_tracker.go:var statusTrackerLog = core.Log.WithName("xds").WithName("statusTracker")
pkg/xds/server/callbacks/dataplane_sync_tracker.go:     dataplaneSyncTrackerLog = core.Log.WithName("xds-server").WithName("dataplane-sync-tracker")
pkg/xds/server/callbacks/nack_backoff.go:var nackLog = core.Log.WithName("xds").WithName("nack-backoff")
pkg/xds/server/v3/components.go:var xdsServerLog = core.Log.WithName("xds-server")
pkg/xds/server/v3/reconcile.go: reconcileLog = core.Log.WithName("xds-server").WithName("reconcile")
pkg/xds/server/v3/resource_warming_forcer.go:var warmingForcerLog = xdsServerLog.WithName("warming-forcer")
pkg/xds/sync/components.go:     xdsServerLog = core.Log.WithName("xds-server")
pkg/xds/sync/dataplane_proxy_builder.go:var syncLog = core.Log.WithName("sync")
pkg/xds/sync/dataplane_watchdog_factory.go:     log := xdsServerLog.WithName("dataplane-sync-watchdog").WithValues("dataplaneKey", proxyId.ToResourceKey())
pkg/xds/template/proxy_template_resolver.go:    templateResolverLog = core.Log.WithName("proxy-template-resolver")

Sometimes we use xds as the parent logger name, sometimes we use xds-server. Some names are hyphenated (proxy-template-resolver) and some are lowerCamelCased (statusTracker).

Would be nice to make these all consistent.

[burntcarrot]

@jpeach I would like to take this one if it's open. Would you prefer camel case or something else?

Just for a sanity check, can you tell me if there are any services dependent on the logger name?

[jpeach]

@jpeach I would like to take this one if it's open.

Great!

Would you prefer camel case or something else?

Lets stick with hyphen-separated-words.

Just for a sanity check, can you tell me if there are any services dependent on the logger name?

Not AFAIK. Would be good to ping on the Kuma slack though.

[jpeach]

I pinged this to the community slack. Let's give people a week to give feedback.

https://kuma-mesh.slack.com/archives/CN2GN4HE1/p1626390711062600

[jpeach]

Remaining work here is to look into the use of WithName("xds"), and WithName("xds-server") and loggers that don't do either.

[github-actions]

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

[github-actions]

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

[github-actions]

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

[github-actions]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[github-actions]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[github-actions]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[github-actions]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[github-actions]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

[lahabana]

It's better than it used too but could still do with a few imporvements:

pkg/xds/bootstrap/handler.go:var log = core.Log.WithName("bootstrap")
pkg/xds/context/context.go:             core.Log.WithName("xds").Info("Tracing backend is not found. Ignoring.",
pkg/xds/context/context.go:             core.Log.WithName("xds").Info("Logging backend is not found. Ignoring.",
pkg/xds/context/mesh_context_builder.go:var logger = core.Log.WithName("xds").WithName("context")
pkg/xds/envoy/clusters/v3/health_check_configurer.go:           core.Log.WithName("health-check-configurer").Error(
pkg/xds/generator/egress/generator.go:var log = core.Log.WithName("xds").WithName("generator").WithName("egress")
pkg/xds/generator/outbound_proxy_generator.go:var outboundLog = core.Log.WithName("outbound-proxy-generator")
pkg/xds/generator/prometheus_endpoint_generator.go:var prometheusLog = core.Log.WithName("prometheus-endpoint-generator")
pkg/xds/generator/secrets/generator.go: log := core.Log.WithName("secrets-generator").WithValues("proxyID", proxyId.String())
pkg/xds/generator/secrets/generator.go: log := core.Log.WithName("secrets-generator").WithValues("proxyID", proxy.Id.String())
pkg/xds/secrets/secrets.go:var log = core.Log.WithName("xds").WithName("secrets")
pkg/xds/server/callbacks/dataplane_lifecycle.go:var lifecycleLog = core.Log.WithName("xds").WithName("dp-lifecycle")
pkg/xds/server/callbacks/dataplane_status_sink.go:var sinkLog = core.Log.WithName("xds").WithName("sink")
pkg/xds/server/callbacks/dataplane_status_tracker.go:var statusTrackerLog = core.Log.WithName("xds").WithName("status-tracker")
pkg/xds/server/callbacks/dataplane_sync_tracker.go:var dataplaneSyncTrackerLog = core.Log.WithName("xds-server").WithName("dataplane-sync-tracker")
pkg/xds/server/callbacks/nack_backoff.go:var nackLog = core.Log.WithName("xds").WithName("nack-backoff")
pkg/xds/server/v3/components.go:var xdsServerLog = core.Log.WithName("xds-server")
pkg/xds/server/v3/context.go:   log := core.Log.WithName(name)
pkg/xds/server/v3/reconcile.go:var reconcileLog = core.Log.WithName("xds-server").WithName("reconcile")
pkg/xds/server/v3/resource_warming_forcer.go:var warmingForcerLog = xdsServerLog.WithName("warming-forcer")
pkg/xds/sync/components.go:var xdsServerLog = core.Log.WithName("xds-server")
pkg/xds/sync/dataplane_watchdog_factory.go:     log := xdsServerLog.WithName("dataplane-sync-watchdog").WithValues("dataplaneKey", dpKey)
pkg/xds/template/proxy_template_resolver.go:var templateResolverLog = core.Log.WithName("proxy-template-resolver")

[github-actions]

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.