Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete method GetLatestSubscription for Insights #2557

Closed
lobkovilya opened this issue Aug 12, 2021 · 2 comments · Fixed by #3656
Closed

Delete method GetLatestSubscription for Insights #2557

lobkovilya opened this issue Aug 12, 2021 · 2 comments · Fixed by #3656
Assignees
@tharun208
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lobkovilya
Copy link
Contributor

Summary

Since we always append the newest subscription at the end of the list, we don't need a method that sorts subscriptions by the ConnectTime and picks the latest. That's why method GetLatestSubscription could be deleted, all usages replaced with GetLastSubscription
@lahabana lahabana added kind/improvement Improvement on an existing feature and removed improvement labels Nov 22, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 25, 2021
@tharun208
Copy link
Contributor

@lobkovilya I like to work on this

tharun208 added a commit to tharun208/kuma that referenced this issue Jan 6, 2022
@tharun208
chore(*) delete method GetLatestSubscription for insights
4702592 
Fixes kumahq#2557

Signed-off-by: Tharun <rajendrantharun@live.com>
@tharun208 tharun208 mentioned this issue Jan 6, 2022
Merged
6 tasks
tharun208 added a commit to tharun208/kuma that referenced this issue Jan 6, 2022
@tharun208
chore(*): delete method GetLatestSubscription for insights
f50ef52 
Fixes kumahq#2557

Signed-off-by: Tharun <rajendrantharun@live.com>
tharun208 added a commit to tharun208/kuma that referenced this issue Jan 6, 2022
@tharun208
refractor(insights): delete method GetLatestSubscription for insights
70a75f1 
Fixes kumahq#2557

Signed-off-by: Tharun <rajendrantharun@live.com>
tharun208 added a commit to tharun208/kuma that referenced this issue Jan 6, 2022
@tharun208
refactor(insights): delete method GetLatestSubscription for insights
b6ec05f 
Fixes kumahq#2557

Signed-off-by: Tharun <rajendrantharun@live.com>
tharun208 added a commit to tharun208/kuma that referenced this issue Jan 7, 2022
@tharun208
refactor(insights): delete method GetLatestSubscription for insights
74d814a 
Fixes kumahq#2557

Signed-off-by: Tharun <rajendrantharun@live.com>
@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/stale Inactive for some time. It will be triaged again labels Jan 7, 2022
lobkovilya pushed a commit that referenced this issue Jan 17, 2022
@tharun208 @mergify
refactor(insights): delete method GetLatestSubscription for insights (#…
dfafe84 
…3656)

* refactor(insights): delete method GetLatestSubscription for insights

Fixes #2557

Signed-off-by: Tharun <rajendrantharun@live.com>

* refactor(insights): cast type while returning error if no insights found

Signed-off-by: Tharun <rajendrantharun@live.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tharun208 tharun208

Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(insights): delete method GetLatestSubscription for insights tharun208/kuma
3 participants
@lahabana @lobkovilya @tharun208