Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update references to deprecated protobuf lib #3499

Closed
parkanzky opened this issue Dec 13, 2021 · 19 comments · Fixed by #12038
Closed

Update references to deprecated protobuf lib #3499

parkanzky opened this issue Dec 13, 2021 · 19 comments · Fixed by #12038
Assignees
@Icarus9913
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone
2.10.x

Comments

@parkanzky
Copy link
Contributor

What happened?

Kuma code imports github.com/golang/protobuf/proto in a number of places. This package is deprecated in favor of google.golang.org/protobuf/proto. Should update everything to recommended package.

Unfortunately, the two packages are not compatible, so need to update all dependencies of any changed module at the same time.
@parkanzky parkanzky added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Dec 13, 2021
@jpeach
Copy link
Contributor

jpeach commented Dec 13, 2021

I think the main blocker is the generated Envoy protobufs, envoyproxy/go-control-plane#524.

@lahabana lahabana added kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Dec 16, 2021
@michaelbeaumont michaelbeaumont mentioned this issue Dec 17, 2021
Closed
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 16, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jul 11, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 10, 2022
@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Oct 31, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 30, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Jan 30, 2023
lahabana added a commit that referenced this issue Mar 7, 2023
@lahabana
chore(xds): remove back compat for old dns filter
ba1a2ef 
This was introduced to support envoy < 1.20 which we no longer need to
support

xref #3499

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana mentioned this issue Mar 7, 2023
Merged
6 tasks
lahabana added a commit that referenced this issue Mar 8, 2023
@lahabana @github-actions
chore(xds): remove back compat for old dns filter (#6226)
4ac717b 
This was introduced to support envoy < 1.20 which we no longer need to
support

xref #3499

---------

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label May 1, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jul 31, 2023
@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Jul 31, 2023
@lukidzi
Copy link
Contributor

lukidzi commented Jul 31, 2023

Looks like there is one more place: https://github.com/kumahq/kuma/blob/master/pkg/plugins/policies/meshloadbalancingstrategy/plugin/xds/lbconfigurer.go#L5

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 30, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Nov 3, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Feb 7, 2024
@lahabana lahabana added this to the 2.8.x milestone Apr 5, 2024
@mmorel-35
Copy link
Contributor

Hi !
Just to let you know that latest versions of cncf/xds and envoyproxy/go-control-plane don’t rely on old protobuf library anymore

@mmorel-35 mmorel-35 mentioned this issue Apr 21, 2024
Closed
5 tasks
@lahabana lahabana modified the milestones: 2.8.x, 2.9.x Apr 24, 2024
@Icarus9913
Copy link
Contributor

on the way

@mmorel-35
Copy link
Contributor

mmorel-35 commented Jun 25, 2024 •
edited
Loading

Finally ! That was such a long way to go 😅! Through xds, envoy, go-control-plane !
I learned Bazel on the way 🥳

@lahabana lahabana modified the milestones: 2.9.x, backlog Jul 2, 2024
@Icarus9913
Copy link
Contributor

Unfortunatlly, the latest v0.12.0 go-control-plane still use golang/protobuf.
https://github.com/envoyproxy/go-control-plane/blob/989e83d4a05c74448fdc72e5a67df5529387c021/go.mod#L9

I'll do this migration once our dependency implemented it.

@mmorel-35
Copy link
Contributor

The latest still supports v1 protobuf but the main branch doesn't, see
https://github.com/envoyproxy/go-control-plane/blob/main/go.mod

@Icarus9913
Copy link
Contributor

The latest still supports v1 protobuf but the main branch doesn't, see https://github.com/envoyproxy/go-control-plane/blob/main/go.mod

The main branch still include the github.com/golang/protobuf v1.5.4

https://github.com/envoyproxy/go-control-plane/blob/108116100bc16c91f49cd50d4b09495471c711c2/go.mod#L24

@mmorel-35
Copy link
Contributor

mmorel-35 commented Jul 3, 2024 •
edited
Loading

Yes but that's not a direct dependency 😅.

@Icarus9913
Copy link
Contributor

Yes but that's not a direct dependency 😅.

Oh, you're right.
I gonna get a try with the next go-control-plane version.

@Icarus9913
Copy link
Contributor

still blocked by envoyproxy/go-control-plane#875

@Icarus9913 Icarus9913 modified the milestones: backlog, 2.10.x Oct 31, 2024
@Icarus9913
Copy link
Contributor

Icarus9913 commented Nov 14, 2024 •
edited
Loading

We can't totally get rid of the old protobuf dependency due to golang/protobuf#1374
So, we would just only keep the github.com/golang/protobuf/jsonpb dependency but update of all others.

@Icarus9913 Icarus9913 mentioned this issue Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Icarus9913 Icarus9913

Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
2.10.x
Development

Successfully merging a pull request may close this issue.

chore(deps): remove deprecated protobuf dependency Icarus9913/kuma
7 participants
@jpeach @lahabana @slonka @mmorel-35 @lukidzi @parkanzky @Icarus9913