Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old kuma.io/builtindns annotations #4675

Closed
lahabana opened this issue Jul 26, 2022 · 2 comments · Fixed by #6224
Closed

Remove old kuma.io/builtindns annotations #4675

lahabana opened this issue Jul 26, 2022 · 2 comments · Fixed by #6224
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

Description

With #4660 we're fixing the annotation in Kuma 1.8 so in 2 versions we need to remove the old annotation
@lahabana lahabana added triage/accepted The issue was reviewed and is complete enough to start working on it kind/cleanup Cleanup/refactor an existing component/code labels Jul 26, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 25, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Oct 25, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 24, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jan 24, 2023
lahabana added a commit that referenced this issue Mar 7, 2023
@lahabana
chore(cleanup): remove old builtindns annotations
2910d0a 
These were deprecated since 1.8.0

Fix #4675

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana mentioned this issue Mar 7, 2023
Merged
6 tasks
lahabana added a commit that referenced this issue Mar 7, 2023
@lahabana
chore(cleanup): remove old builtindns annotations
1c5271c 
These were deprecated since 1.8.0

Fix #4675

Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana added a commit that referenced this issue Mar 7, 2023
@lahabana
chore(cleanup): remove old builtindns annotations (#6224)
f6a4e01 
These were deprecated since 1.8.0

Fix #4675

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(cleanup): remove old builtindns annotations kumahq/kuma
1 participant
@lahabana