Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serviceless pods and provided gateway should use deployment,daemonset,jobs name #4768

Closed
lahabana opened this issue Aug 4, 2022 · 2 comments · Fixed by #5569
Closed

Serviceless pods and provided gateway should use deployment,daemonset,jobs name #4768

lahabana opened this issue Aug 4, 2022 · 2 comments · Fixed by #5569
Assignees
@lukidzi
Labels
area/k8s kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

lahabana commented Aug 4, 2022

Description

As #4747 and #4703 (comment) revealed the way we extract deployment name in serviceless pods doesn't support: Jobs, DaemonSets and Stateful sets.
For provided gateway we're adding support of deployments which looking at the parentRef (#4703), this a better more reliable way that we should use for serviceless pods and extends to pods created by Jobs, DaemonSets and StatefulSets.
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Aug 4, 2022
@lahabana lahabana mentioned this issue Aug 4, 2022
Closed
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Aug 8, 2022
@jakubdyszkiewicz
Copy link
Contributor

As part of this issue, test if we fixed this problem #4747

@lahabana
Copy link
Contributor Author

LEt's also make sure that backward compatibility is presserved

@lukidzi lukidzi mentioned this issue Jan 3, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukidzi lukidzi

Labels
area/k8s kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(kuma-cp): retrieve name from owner not parsing pod name for Deployments/CronJob lukidzi/kuma
3 participants
@lahabana @jakubdyszkiewicz @lukidzi