fix(kuma-cp): retrieve name from owner not parsing pod name for Deployments/CronJob #5569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ronJob Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi
requested review from
a team,
jakubdyszkiewicz and
Automaat
and removed request for
a team
lukidzi
commented
Jan 3, 2023
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
pkg/plugins/runtime/k8s/controllers/serviceless_name_extractor.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
jakubdyszkiewicz
approved these changes
Jan 4, 2023
lahabana
reviewed
Jan 5, 2023
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
bartsmykla
pushed a commit
to bartsmykla/kuma
that referenced
this pull request
Jan 14, 2023
Currently, for seviceless, we are retrieving the name by splitting the pod name and removing the 2 last elements. This is correct but only for Deployments and CronJob because they are creating an intermediate object that manages Pod(ReplicaSet,Job). Example: Deployment name = test ReplicaSet name = test-hash Pod name = test-hash-hash2 In the case of ReplicaSet/Job/Pod/DaemonSet it might produce the wrong name: Example: ReplicaSet name = test-server Pod name = test-server-hash result = test Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com> Signed-off-by: Bart Smykla <bartek@smykla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for seviceless, we are retrieving the name by splitting the pod name and removing the 2 last elements. This is correct but only for Deployments and CronJob because they are creating an intermediate object that manages Pod(ReplicaSet,Job).
Example:
In the case of ReplicaSet/Job/Pod/DaemonSet it might produce the wrong name:
Example:
Introduced change which retrieves for Deployments and CronJob name from the owner. Because of keeping backward compatibility, I had to leave the code with splitting for all cases that are not CronJob or Deployment to not introduce braking change. If we think that we want to introduce breaking change I am happy to change it because without we might have problems with overlapping names.
Example:
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?