Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove opt-out of insights #4854

Closed
jakubdyszkiewicz opened this issue Aug 18, 2022 · 1 comment · Fixed by #4894
Closed

Remove opt-out of insights #4854

jakubdyszkiewicz opened this issue Aug 18, 2022 · 1 comment · Fixed by #4894
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@jakubdyszkiewicz
Copy link
Contributor

Description

Remove KUMA_METRICS_DATAPLANE_ENABLED. We rely on this now in different parts of the code.
@jakubdyszkiewicz jakubdyszkiewicz added triage/pending This issue will be looked at on the next triage meeting kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Aug 18, 2022
@jakubdyszkiewicz
Copy link
Contributor Author

Triage: we already removed this. Let's remove this from kuma-cp defaults file.

lahabana added a commit to lahabana/kuma that referenced this issue Aug 24, 2022
@lahabana
cleanup: remove disabling metrics from kuma-cp.defaults
f4e643e 
These are not optional for a while. Add a test to check to kuma-cp.defaults.yaml
doesn't not contain extra configs

Fix kumahq#4854

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana mentioned this issue Aug 24, 2022
Merged
11 tasks
lahabana added a commit that referenced this issue Aug 24, 2022
@lahabana
chore(kuma-cp): remove disabling metrics from kuma-cp.defaults (#4894)
c39c8d1 
cleanup: remove disabling metrics from kuma-cp.defaults

These are not optional for a while. Add a test to check to kuma-cp.defaults.yaml
doesn't not contain extra configs

Fix #4854

Signed-off-by: Charly Molter <charly.molter@konghq.com>

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(kuma-cp): remove disabling metrics from kuma-cp.defaults lahabana/kuma
1 participant
@jakubdyszkiewicz