Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fixed point percentage instead of int in MeshTrace #5716

Closed
lahabana opened this issue Jan 16, 2023 · 2 comments
Closed

Use fixed point percentage instead of int in MeshTrace #5716

lahabana opened this issue Jan 16, 2023 · 2 comments
Assignees
@jakubdyszkiewicz @lobkovilya
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

What happened?

This allow decimal and is a format users are used to.
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Jan 16, 2023
@lahabana lahabana changed the title Use *k8s.Quantity instead of int in MeshTrace Use fixed point percentage instead of int in MeshTrace Jan 16, 2023
@lahabana
Copy link
Contributor Author

use the same type as #5717

@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jan 16, 2023
@lahabana lahabana mentioned this issue Jan 20, 2023
Merged
12 tasks
@jakubdyszkiewicz
Copy link
Contributor

fixed by #5768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakubdyszkiewicz jakubdyszkiewicz

@lobkovilya lobkovilya

Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lahabana @jakubdyszkiewicz @lobkovilya