feat(kuma-cp): intOrString as decimal in the API #5768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
jakubdyszkiewicz
force-pushed
the
chore/percentage-intorstr
branch
from
173f5ce to
f286b0e
Compare
jakubdyszkiewicz
requested review from
a team,
slonka and
Automaat
and removed request for
a team
michaelbeaumont
approved these changes
Jan 20, 2023
| @@ -159,8 +159,13 @@ func configureSuccessRate( | |||
| } | |||
|
|
|||
| if conf.StandardDeviationFactor != nil { | |||
| outlierDetection.SuccessRateStdevFactor = util_proto.UInt32(*conf.StandardDeviationFactor) | |||
| dec, err := v1alpha1.NewDecimalFromIntOrString(*conf.StandardDeviationFactor) | |||
There was a problem hiding this comment.
Ideally we'd have a type in between here to avoid dealing with these impossible errors. Maybe we could even panic here? It has been validated after all...
There was a problem hiding this comment.
I don't know how could we introduce type in between because of #5768 (comment)
It's a good question whether we should panic or not after we validate in the first place.
In this PR I'd like to keep the err, but I'd love to resume a discussion in form of the issue, MADR or offline discussion within the team.
This was referenced Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
IntOrStringin API for decimal.Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?