Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add x-kuma-tags header to MeshHealthcheck requests #5718

Closed
lahabana opened this issue Jan 16, 2023 · 0 comments · Fixed by #5722
Closed

Add x-kuma-tags header to MeshHealthcheck requests #5718

lahabana opened this issue Jan 16, 2023 · 0 comments · Fixed by #5722
Assignees
@lahabana
Labels
area/policies kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

Description

This enables policies to apply even to healthcheck requests
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature area/policies labels Jan 16, 2023
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jan 16, 2023
@lahabana lahabana self-assigned this Jan 16, 2023
lahabana added a commit to lahabana/kuma that referenced this issue Jan 16, 2023
@lahabana
feat(meshhealthcheck): add x-kuma-tags to requests
66fece8 
We add x-kuma-tags to all requests that way things like faultInjection
can also apply to health checks

Fix kumahq#5718

Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana added a commit to lahabana/kuma that referenced this issue Jan 16, 2023
@lahabana
feat(meshhealthcheck): add x-kuma-tags to requests
f6abb38 
We add x-kuma-tags to all requests that way things like faultInjection
can also apply to health checks

Fix kumahq#5718

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana mentioned this issue Jan 16, 2023
Merged
12 tasks
lahabana added a commit that referenced this issue Jan 17, 2023
@lahabana
feat(meshhealthcheck): add x-kuma-tags to requests (#5722)
9648bc6 
We add x-kuma-tags to all requests that way things like faultInjection
can also apply to health checks

Fix #5718

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lahabana lahabana

Labels
area/policies kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(meshhealthcheck): add x-kuma-tags to requests lahabana/kuma
2 participants
@lahabana @jakubdyszkiewicz