Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshTrafficPermission doesn't work for ExternalServices that have different name and service #7164

Closed
lobkovilya opened this issue Jul 4, 2023 · 0 comments · Fixed by #7225
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lobkovilya
Copy link
Contributor

What happened?

Root cause:

We're using es.Meta.GetName() instead of kuma.io/service tag:

for _, es := range resource.ExternalServices {
meshName := resource.Mesh.GetMeta().GetName()
esName := es.Meta.GetName()
policies, ok := resource.Dynamic[esName]
if !ok {
continue
}

Also, e2e test should use ExternalService with a different name and service:

type: ExternalService
mesh: "%s"
name: external-service
tags:
kuma.io/service: external-service
kuma.io/protocol: http
networking:
address: "%s"
`, mesh, net.JoinHostPort(ip, "80")))

@lobkovilya lobkovilya added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Jul 4, 2023
@michaelbeaumont michaelbeaumont added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants