Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MeshTrafficPermission): use serviceName instead of resource name for egress MTP #7225

Merged
merged 2 commits into from
Jul 13, 2023
Merged

fix(MeshTrafficPermission): use serviceName instead of resource name for egress MTP #7225

merged 2 commits into from
Jul 13, 2023

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Jul 12, 2023

Checklist prior to review

@lukidzi
fix(kuma-cp): use serviceName instead of resource name for egress wit…
f7660b9 
…h MTP

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from a team as a code owner July 12, 2023 13:24
@lukidzi lukidzi requested review from Automaat and lobkovilya and removed request for a team July 12, 2023 13:24
@lukidzi
fix(kuma-cp): trigger build
62266c2 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@michaelbeaumont michaelbeaumont changed the title fix(kuma-cp): use serviceName instead of resource name for egress MTP fix(MeshTrafficPermission): use serviceName instead of resource name for egress MTP Jul 13, 2023
@lukidzi
Copy link
Contributor Author

lukidzi commented Jul 13, 2023

I think we can backport it to 2.3 @lahabana WDYT?

@lahabana
Copy link
Contributor

If there's no way for a current user to rely on the old behaviour let's backport to 2.3 only

@lukidzi lukidzi merged commit e6ced10 into kumahq:master Jul 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023 •
edited
Loading

backporting to release-2.1 with action

backporting to release-2.3 with action
backporting to release-2.2 with action
backporting to release-2.0 with action
backporting to release-1.8 with action

This was referenced Jul 13, 2023
Closed
Merged
kumahq bot pushed a commit that referenced this pull request Jul 13, 2023
@lukidzi @kumahq
fix(MeshTrafficPermission): use serviceName instead of resource name …
71228f5 
…for egress MTP (#7225)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot pushed a commit that referenced this pull request Jul 13, 2023
@lukidzi @kumahq
fix(MeshTrafficPermission): use serviceName instead of resource name …
fdc37b6 
…for egress MTP (#7225)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
kumahq bot pushed a commit that referenced this pull request Jul 13, 2023
@lukidzi @kumahq
fix(MeshTrafficPermission): use serviceName instead of resource name …
790fa58 
…for egress MTP (#7225)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
This was referenced Jul 13, 2023
Closed
Closed
kumahq bot pushed a commit that referenced this pull request Jul 13, 2023
@lukidzi @kumahq
fix(MeshTrafficPermission): use serviceName instead of resource name …
ced769c 
…for egress MTP (#7225)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@kumahq kumahq bot mentioned this pull request Jul 13, 2023
Closed
kumahq bot pushed a commit that referenced this pull request Jul 13, 2023
@lukidzi @kumahq
fix(MeshTrafficPermission): use serviceName instead of resource name …
8397f11 
…for egress MTP (#7225)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi added a commit that referenced this pull request Jul 13, 2023
@lukidzi
fix(MeshTrafficPermission): use serviceName instead of resource name …
6bf2072 
…for egress MTP (#7225)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
lukidzi pushed a commit that referenced this pull request Jul 13, 2023
@kumahq
fix(MeshTrafficPermission): use serviceName instead of resource name …
1a569ea 
…for egress MTP (backport of #7225) (#7233)

fix(MeshTrafficPermission): use serviceName instead of resource name for egress MTP (#7225)

Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MeshTrafficPermission doesn't work for ExternalServices that have different name and service
2 participants
@lukidzi @lahabana