Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*) fix transparent-proxy for GCP/GKE #2051

Merged
merged 1 commit into from
May 27, 2021
Merged

fix(*) fix transparent-proxy for GCP/GKE #2051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions pkg/transparentproxy/istio/tools/istio-iptables/pkg/cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"fmt"
"net"
"os"
"os/exec"
"os/user"
"strconv"
"strings"
Expand Down Expand Up @@ -122,11 +123,11 @@ func constructConfig() *config.Config {
}

// Kuma modification start
hasIPv6, err := hasLocalIPv6()
enableIPv6, err := shouldEnableIPv6()
if err != nil {
panic(err)
}
cfg.EnableInboundIPv6 = hasIPv6
cfg.EnableInboundIPv6 = enableIPv6
// Kuma modification end

// Lookup DNS nameservers. We only do this if DNS is enabled in case of some obscure theoretical
Expand Down Expand Up @@ -175,6 +176,22 @@ func hasLocalIPv6() (bool, error) {
return false, nil
}

func shouldEnableIPv6() (bool, error) {
hasIPv6Address, err := hasLocalIPv6()
if !hasIPv6Address || err != nil {
return false, err
}

// We are executing this command to work around the problem with COS_CONTAINERD
// image which is being used on GKE nodes. This image is missing "ip6tables_nat`
// kernel module which is adding `nat` table, so we are checking if this table
// exists and if so, we are assuming we can safely proceed with ip6tables
// ref. https://github.com/kumahq/kuma/issues/2046
err = exec.Command(constants.IP6TABLES, "-t", constants.NAT, "-L").Run()

return err == nil, nil
}

// Kuma modification end

func handleError(err error) {
Expand Down