Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kumactl) warn version unknown (backport #2438) #2442

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 27, 2021

This is an automatic backport of pull request #2438 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@mergify mergify bot requested a review from a team as a code owner July 27, 2021 17:28
* fix(kumactl) Warn when server version cannot be retrieved

Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>

* fix(kumactl) Warn when server version cannot be retrieved

Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>

* fix(kumactl) Add mock client

Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>

* fix(kumactl) make check

Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>

* chore(*) address review comments

Signed-off-by: Bart Smykla <bartek@smykla.com>

* chore(*) make check results

Signed-off-by: Bart Smykla <bartek@smykla.com>

* chore(*) update config cp add tests

Signed-off-by: Bart Smykla <bartek@smykla.com>

* chore(*) rename import kuma_test to default

also sorted imports in some of the tests

Signed-off-by: Bart Smykla <bartek@smykla.com>

* chore(*) fix config cp kumactl remove tests

Signed-off-by: Bart Smykla <bartek@smykla.com>

Co-authored-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
(cherry picked from commit 755ccf8)
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
@parkanzky parkanzky force-pushed the mergify/bp/release-1.2/pr-2438 branch from 3faf933 to c82cb05 Compare July 27, 2021 18:06
@parkanzky parkanzky merged commit 7341591 into release-1.2 Jul 27, 2021
@parkanzky parkanzky deleted the mergify/bp/release-1.2/pr-2438 branch July 27, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant