Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci) kumactl test output matching #2446

Merged
merged 1 commit into from
Jul 29, 2021
Merged

fix(ci) kumactl test output matching #2446

merged 1 commit into from
Jul 29, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jul 29, 2021

Summary

This test failure is a result of the combination of #2419 and #2438.

The fix is to test for error output using a substring match, which was
already done in most places in #2438, but this instance was overlooked.

Full changelog

N/A

Issues resolved

N/A

Documentation

NA

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@jpeach jpeach requested a review from a team as a code owner July 29, 2021 00:45
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021

Codecov Report

Merging #2446 (bb90794) into master (2bc0a3f) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2446   +/-   ##
=======================================
  Coverage   52.55%   52.55%           
=======================================
  Files         878      879    +1     
  Lines       47904    47923   +19     
=======================================
+ Hits        25177    25188   +11     
- Misses      20680    20684    +4     
- Partials     2047     2051    +4     
Impacted Files Coverage Δ
app/kumactl/cmd/root.go 73.68% <50.00%> (-5.57%) ⬇️
pkg/util/test/mock_api_client.go 100.00% <100.00%> (ø)
app/kumactl/pkg/resources/apiserver_client.go 35.00% <0.00%> (-45.00%) ⬇️
pkg/insights/components.go 70.00% <0.00%> (-30.00%) ⬇️
app/kumactl/pkg/client/api_server_client.go 66.66% <0.00%> (-16.67%) ⬇️
app/kumactl/pkg/resources/request.go 50.00% <0.00%> (-14.29%) ⬇️
pkg/util/http/tls.go 70.00% <0.00%> (-10.00%) ⬇️
pkg/insights/resyncer.go 64.70% <0.00%> (-0.85%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 755ccf8...bb90794. Read the comment docs.

This test failure is a result of the combination of #2419 and #2438.

The fix is to test for error output using a substring match, which was
already done in most places in #2438, but this instance was overlooked.

Signed-off-by: James Peach <james.peach@konghq.com>
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jpeach jpeach merged commit 10d4926 into kumahq:master Jul 29, 2021
mergify bot pushed a commit that referenced this pull request Jul 29, 2021
This test failure is a result of the combination of #2419 and #2438.

The fix is to test for error output using a substring match, which was
already done in most places in #2438, but this instance was overlooked.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 10d4926)
@jpeach jpeach deleted the fix/kumactl-switch-tests branch July 29, 2021 05:04
jpeach added a commit that referenced this pull request Jul 29, 2021
This test failure is a result of the combination of #2419 and #2438.

The fix is to test for error output using a substring match, which was
already done in most places in #2438, but this instance was overlooked.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 10d4926)

Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants