Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(traffic-log): remove extra endline in traffic log default template (backport #2514) #2653

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 24, 2021

This is an automatic backport of pull request #2514 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

#2514)

We were adding a new line twice. Once in the default template and once in
`convertLoggingBackend` this was introducing empty lines in log files

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 3665e51)
@mergify mergify bot requested a review from a team as a code owner August 24, 2021 10:12
@bartsmykla
Copy link
Contributor

there is new, release-1.3 branch from master, so this PR is unnecessary

@bartsmykla bartsmykla closed this Aug 24, 2021
@bartsmykla bartsmykla deleted the mergify/bp/release-1.2/pr-2514 branch August 24, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants