chore(*) update Envoy to 1.20 #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2967 +/- ##
==========================================
- Coverage 52.30% 52.25% -0.06%
==========================================
Files 927 929 +2
Lines 54066 54429 +363
==========================================
+ Hits 28281 28440 +159
- Misses 23573 23763 +190
- Partials 2212 2226 +14
Continue to review full report at Codecov.
|
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> # Conflicts: # app/kuma-dp/cmd/run.go # app/kuma-dp/pkg/dataplane/envoy/remote_bootstrap.go # app/kuma-dp/pkg/dataplane/envoy/remote_bootstrap_test.go # pkg/config/xds/bootstrap/config.go # pkg/xds/bootstrap/types/bootstrap_request.go
jpeach
reviewed
Oct 22, 2021
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
jpeach
suggested changes
Oct 25, 2021
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
jpeach
approved these changes
Oct 25, 2021
|
@lobkovilya I'm not sure that this should be backported. Do we really want to churn an Envoy version in a stable release train? |
|
@jpeach yeah, probably we don't want |
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> # Conflicts: # go.mod # go.sum # mk/test.mk # tools/releases/dockerfiles/Dockerfile.kuma-dp
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
|
@lobkovilya Does this need another review pass? |
|
@jpeach yes please, it'd be great :) |
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> # Conflicts: # pkg/xds/server/v3/reconcile_test.go
jpeach
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
based on #2965
Since Envoy renamed
v3alphatov3, we have to vendor the old DNS filter proto:Full changelog
github.com/envoyproxy/go-control-plane v0.9.10-0.20211007073556-ab721e93c590Issues resolved
Fix #2713
Documentation
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.