Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable reporting by default (#3070)" (backport #3072) #3081

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 4, 2021

This is an automatic backport of pull request #3072 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

Revert changing the telemetry defaults pending discussion with CNCF.

This reverts commit c259c6c.
Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit bc68c58)
@mergify mergify bot requested a review from a team as a code owner November 4, 2021 04:27
@codecov-commenter
Copy link

Codecov Report

Merging #3081 (b9adac8) into release-1.3 (4117839) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.3    #3081      +/-   ##
===============================================
+ Coverage        51.77%   51.89%   +0.12%     
===============================================
  Files              887      887              
  Lines            52053    52053              
===============================================
+ Hits             26951    27014      +63     
+ Misses           22967    22884      -83     
- Partials          2135     2155      +20     
Impacted Files Coverage Δ
pkg/config/app/kuma-cp/config.go 51.47% <100.00%> (ø)
pkg/xds/cache/once/cache.go 94.87% <0.00%> (+7.69%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️
.../apis/external_service/external_service_manager.go 45.16% <0.00%> (+9.67%) ⬆️
pkg/core/runtime/reports/reports.go 53.63% <0.00%> (+40.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4117839...b9adac8. Read the comment docs.

@jpeach jpeach merged commit 3f4d7a5 into release-1.3 Nov 4, 2021
@jpeach jpeach deleted the mergify/bp/release-1.3/pr-3072 branch November 4, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants