Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable reporting by default (#3070) (backport #3159) #3160

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 16, 2021

This is an automatic backport of pull request #3159 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

There is reporting code in Kuma that sends data to
kong-hf.konghq.com by default. This commit switches
the default to false for now.

Updates #3050.

Signed-off-by: Hart Hoover <hart.hoover@gmail.com>
Signed-off-by: Charly Molter <charly.molter@konghq.com>

Co-authored-by: Hart Hoover <hhoover@users.noreply.github.com>
(cherry picked from commit b723e23)
@mergify mergify bot requested a review from a team as a code owner November 16, 2021 09:31
@codecov-commenter
Copy link

Codecov Report

Merging #3160 (5c310e0) into release-1.3 (dbdbab2) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.3    #3160      +/-   ##
===============================================
- Coverage        51.87%   51.79%   -0.08%     
===============================================
  Files              887      887              
  Lines            52059    52059              
===============================================
- Hits             27005    26965      -40     
- Misses           22904    22954      +50     
+ Partials          2150     2140      -10     
Impacted Files Coverage Δ
pkg/config/app/kuma-cp/config.go 51.47% <100.00%> (ø)
pkg/core/runtime/reports/reports.go 12.72% <0.00%> (-39.10%) ⬇️
.../apis/external_service/external_service_manager.go 35.48% <0.00%> (-9.68%) ⬇️
pkg/plugins/leader/postgres/leader_elector.go 93.61% <0.00%> (-4.26%) ⬇️
pkg/mads/v1/client/client.go 41.25% <0.00%> (-2.50%) ⬇️
api/observability/v1/mads.pb.go 34.53% <0.00%> (-1.04%) ⬇️
pkg/core/resources/manager/cache.go 84.41% <0.00%> (+2.59%) ⬆️
pkg/core/runtime/component/component.go 88.67% <0.00%> (+7.54%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbdbab2...5c310e0. Read the comment docs.

@michaelbeaumont michaelbeaumont merged commit 95b0e9c into release-1.3 Nov 16, 2021
@michaelbeaumont michaelbeaumont deleted the mergify/bp/release-1.3/pr-3159 branch November 16, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants